Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong inspections when a model has a __call__ method #655

Merged
merged 3 commits into from
Feb 26, 2023

Conversation

koxudaxi
Copy link
Owner

Closes: #651

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 73.48% // Head: 73.74% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (718e6f0) compared to base (f6dc739).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   73.48%   73.74%   +0.25%     
==========================================
  Files          24       24              
  Lines        1886     1889       +3     
  Branches      586      589       +3     
==========================================
+ Hits         1386     1393       +7     
+ Misses        200      199       -1     
+ Partials      300      297       -3     
Impacted Files Coverage Δ
src/com/koxudaxi/pydantic/Pydantic.kt 76.75% <0.00%> (-0.25%) ⬇️
src/com/koxudaxi/pydantic/PydanticAnnotator.kt 90.90% <100.00%> (+0.43%) ⬆️
src/com/koxudaxi/pydantic/PydanticInspection.kt 83.72% <100.00%> (+0.54%) ⬆️
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 75.56% <0.00%> (+0.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit 1f34d0d into master Feb 26, 2023
@koxudaxi koxudaxi deleted the fix_wrong_inspection_when_model_has_call_method branch February 26, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a BaseModel has a __call__ method, the IDE warns that the call method only accepts kwargs
1 participant