Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inspection for default factory #605

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

koxudaxi
Copy link
Owner

Closes #535

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 73.03% // Head: 73.55% // Increases project coverage by +0.51% 🎉

Coverage data is based on head (5191fa8) compared to base (1b9e20a).
Patch coverage: 88.37% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   73.03%   73.55%   +0.51%     
==========================================
  Files          24       24              
  Lines        1810     1853      +43     
  Branches      558      572      +14     
==========================================
+ Hits         1322     1363      +41     
+ Misses        200      199       -1     
- Partials      288      291       +3     
Impacted Files Coverage Δ
...koxudaxi/pydantic/PydanticDataclassTypeProvider.kt 69.81% <ø> (ø)
src/com/koxudaxi/pydantic/PydanticInspection.kt 83.17% <88.37%> (+1.89%) ⬆️
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 74.88% <0.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit 1a94781 into master Dec 13, 2022
@koxudaxi koxudaxi deleted the inspect_default_factory_type branch December 13, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if default_factory type does not match annotated type
1 participant