Refactor project to be more inline with Jetbrains intellij platform plugin template #436

KotlinIsland · 2022-02-08T06:15:21Z

Refactor a lot of the build / workflow to match: https://github.com/JetBrains/intellij-platform-plugin-template

Updated Gradle to 7.4
Convert build.gradle to Kotlin
Updated Kotlin to 1.6.10
Simplified dependencies:
- Removed kotlin stdlib
- Migrated junit.jupiter to kotlin.test
- Removed jetbrains.annotations
Adopted Qodana and integrated it into the CI
Adopted the changelog Gradle plugin and integrated it into the CI
Add support for 2022.1

These changes simplify the sources of data within the project:

Extracting the high level config from the build script / plugin.xml simplifies making changes.
Moving the changelog into CHANGLOG.md makes it more accessible.

I also updated some issues I found in the markdown documents:

Minor spelling mistakes
Updated links
Removing $ from sample commands so that they are copypaste-able and runnable from within the IDE.

And convert all the Java to Kotlin.

closes: #434
closes: #433
closes: #429
closes: #428

Github sucks and says that I deleted some files when I was actually very careful to rename them to preserve the history.

I'm sure I broke some things 😬. But I hope you like this change :)

KotlinIsland · 2022-02-08T08:01:22Z

I noticed that #430 will cause a lot of conflicts, do you want me to include 2022.1 support in this pr as well?

koxudaxi · 2022-02-08T16:27:59Z

@KotlinIsland Thank you for creating the cool PR. 😍
Did you know why LGTM analyses are failed?

I noticed that #430 will cause a lot of conflicts, do you want me to include 2022.1 support in this pr as well?

If we can support 2022.1 and 2021.3 then I want to include 2022.1.
Can we do it?

KotlinIsland · 2022-02-08T23:14:56Z

@koxudaxi Awesome that you like the sound of this pr!

I'm not sure what LTGM is, I've never used it before, but it looks like it is also failing in #430

Seeing as the project now has zero java, is this even required? Maybe we should use Qodana instead?

KotlinIsland · 2022-02-08T23:28:59Z

If we can support 2022.1 and 2021.3 then I want to include 2022.1.

I think so, the plugin verify step passed for 213 and 221
https://github.com/koxudaxi/pydantic-pycharm-plugin/runs/5112235486?check_suite_focus=true#step:10:65

KotlinIsland · 2022-02-08T23:30:37Z

resources/META-INF/plugin.xml

@@ -1,394 +1,7 @@
 <idea-plugin url="https://github.com/koxudaxi/pydantic-pycharm-plugin" require-restart="true">


@koxudaxi Does the plugin need restart? The plugin verify step said that it could be installed without restart

https://github.com/koxudaxi/pydantic-pycharm-plugin/runs/5112235486?check_suite_focus=true#step:10:72

Plugin can be loaded/unloaded without IDE restart

@KotlinIsland
I forget why I add the restart option 🤔
If we don't need the option then we should remove it.

Seems you changed it with message "Fix build warning", I've removed it now and will see if there are any build warnings.

KotlinIsland · 2022-02-09T01:58:40Z

build.gradle.kts

+
+// Configure Gradle IntelliJ Plugin - read more: https://github.com/JetBrains/gradle-intellij-plugin
+intellij {
+    pluginName.set(properties("pluginName"))


Previously this was pluginName = project.name(pydantic-pycharm-plugin), but this change makes it "Pydantic", I'm not sure what you would want here.

Me too, I forget about the code😅
We should remove the code.

KotlinIsland · 2022-02-09T04:04:49Z

build.gradle.kts

+        certificateChain.set(System.getenv("CERTIFICATE_CHAIN"))
+        privateKey.set(System.getenv("PRIVATE_KEY"))
+        password.set(System.getenv("PRIVATE_KEY_PASSWORD"))


I can't see any of this configuration from before this merge, maybe this section should be removed?

codecov · 2022-02-11T10:45:42Z

Codecov Report

Merging #436 (5a93e51) into master (c2af658) will increase coverage by 0.63%.
The diff coverage is 2.63%.

@@             Coverage Diff              @@
##             master     #436      +/-   ##
============================================
+ Coverage     73.07%   73.70%   +0.63%     
- Complexity      277      305      +28     
============================================
  Files            23       23              
  Lines          1675     1681       +6     
  Branches        506      514       +8     
============================================
+ Hits           1224     1239      +15     
- Misses          166      176      +10     
+ Partials        285      266      -19

Flag	Coverage Δ
unittests	`73.70% <2.63%> (+0.63%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/com/koxudaxi/pydantic/PydanticConfigPanel.kt	`0.00% <0.00%> (ø)`
...koxudaxi/pydantic/PydanticTypeCheckerInspection.kt	`88.65% <33.33%> (ø)`
src/com/koxudaxi/pydantic/Pydantic.kt	`73.64% <0.00%> (-0.24%)`	⬇️
...koxudaxi/pydantic/PydanticCompletionContributor.kt	`84.65% <0.00%> (-0.14%)`	⬇️
src/com/koxudaxi/pydantic/PydanticRegexInjector.kt	`85.71% <0.00%> (ø)`
...om/koxudaxi/pydantic/PydanticParametersProvider.kt	`100.00% <0.00%> (ø)`
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt	`75.69% <0.00%> (+0.05%)`	⬆️
src/com/koxudaxi/pydantic/PydanticConfigService.kt	`88.88% <0.00%> (+0.65%)`	⬆️
src/com/koxudaxi/pydantic/PydanticInspection.kt	`79.37% <0.00%> (+0.75%)`	⬆️
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt	`92.59% <0.00%> (+2.02%)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9205dda...5a93e51. Read the comment docs.

koxudaxi · 2022-02-12T13:22:03Z

Thank you for your changes.
I'm checking the commits!!

koxudaxi · 2022-02-12T13:37:41Z

@KotlinIsland

Seeing as the project now has zero java, is this even required? Maybe we should use Qodana instead?

That makes sense.
I don't know about Qodana . The tools can check kotlin's code?

KotlinIsland · 2022-02-12T15:22:30Z

@koxudaxi

I don't know about Qodana . The tools can check kotlin's code?

Qodan is a code quality tool developed by JetBrains that supports Kotlin, It's recommended by the Jetbrains IntelliJ platform plugin template, and is basically the official Kotlin code quality tool.

It has Gradle support, CLI support, Ide support and A dedicated Github App.

koxudaxi · 2022-02-12T15:26:35Z

@KotlinIsland

It has Gradle support, CLI support, Ide support and A dedicated Github App.
Great!!

It has Gradle support, CLI support, Ide support and A dedicated Github App.
Could you please set up Qodana? And remove LGTM in GitHub Action?

KotlinIsland · 2022-02-12T15:31:13Z

@koxudaxi

I have added Qodana to the CI. I am unable to remove LGTM, I think it is a project setting.

If you would like to add the Github Qodana App(Which I recommend) look here to sign up and register this project.

koxudaxi · 2022-02-12T15:40:50Z

@KotlinIsland
I have deactivated LGTM and set up Qodana App!!

koxudaxi

@KotlinIsland
LGTM
Can I merge the PR?

koxudaxi · 2022-02-12T16:39:52Z

@KotlinIsland
I can't use the service?
Should I send an email to the address?

KotlinIsland · 2022-02-13T00:19:20Z

Yeah, you need to send an email at the moment

https://www.jetbrains.com/help/qodana/qodana-github-application.html#how-to-start-github-app

koxudaxi · 2022-02-14T14:14:40Z

Yeah, you need to send an email at the moment

https://www.jetbrains.com/help/qodana/qodana-github-application.html#how-to-start-github-app

I just sent the request.

koxudaxi · 2022-02-14T17:35:48Z

@KotlinIsland
I joined the group. But, the tools didn't run. :(
#440

KotlinIsland · 2022-02-15T06:46:30Z

@koxudaxi
Did you get a response email from JetBrains yet? If you have then maybe send them another email with follow up explaining that it's not working. Strangely my projects have stopped working with the Qodana app today as well.

Qodana is currently integrated into the build workflow, and you can download the report from the workflow here

koxudaxi · 2022-02-15T14:02:53Z

@KotlinIsland
I found the message from the support team in the mailbox.

I suggest you also try Qodana Scan. It's a GitHub action with more flexible settings and abilities than the app. And it's likely that we'll drop support of the app in the near future.

…lugin-template PT1

…lugin-template PT2

koxudaxi · 2022-02-22T15:47:19Z

@KotlinIsland
Thank you for your great job.
I have released the version.
But, I find an error in the action.
Do you know the reason for the error?
https://github.com/koxudaxi/pydantic-pycharm-plugin/runs/5290676713?check_suite_focus=true

KotlinIsland · 2022-02-23T00:24:49Z

@koxudaxi I know the issue, I'll make a pr soon, it's related to the branch names.

KotlinIsland force-pushed the refactor_project branch 10 times, most recently from 36bb595 to cbba0a0 Compare February 8, 2022 07:58

KotlinIsland force-pushed the refactor_project branch 3 times, most recently from 6b54400 to 13cc893 Compare February 8, 2022 11:53

KotlinIsland force-pushed the refactor_project branch from 13cc893 to 5b299d8 Compare February 8, 2022 23:20

KotlinIsland commented Feb 8, 2022

View reviewed changes

KotlinIsland force-pushed the refactor_project branch 7 times, most recently from 7beaebc to e9315a7 Compare February 9, 2022 00:35

KotlinIsland commented Feb 9, 2022

View reviewed changes

KotlinIsland force-pushed the refactor_project branch 2 times, most recently from b8cec05 to 39a9229 Compare February 11, 2022 02:32

KotlinIsland force-pushed the refactor_project branch 4 times, most recently from 0db891d to 63a0108 Compare February 11, 2022 03:15

KotlinIsland force-pushed the refactor_project branch from 63a0108 to a31c2bb Compare February 12, 2022 04:58

KotlinIsland force-pushed the refactor_project branch from a31c2bb to 0ddd6b1 Compare February 12, 2022 15:25

koxudaxi self-requested a review February 12, 2022 16:36

koxudaxi approved these changes Feb 12, 2022

View reviewed changes

koxudaxi force-pushed the refactor_project branch from 0ddd6b1 to d653191 Compare February 14, 2022 14:23

KotlinIsland added 2 commits February 16, 2022 10:12

refactor project to be more inline with JetBrains intellij-platform-p…

577858c

…lugin-template PT1

refactor project to be more inline with JetBrains intellij-platform-p…

5a93e51

…lugin-template PT2

KotlinIsland force-pushed the refactor_project branch from d653191 to 5a93e51 Compare February 16, 2022 00:13

koxudaxi merged commit 59dc893 into koxudaxi:master Feb 20, 2022

KotlinIsland mentioned this pull request Feb 23, 2022

Fix issue where changelog PRs were failing to generate #443

Merged

KotlinIsland mentioned this pull request Mar 12, 2022

2022.1 support VirtusLab/git-machete-intellij-plugin#789

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor project to be more inline with Jetbrains intellij platform plugin template #436

Refactor project to be more inline with Jetbrains intellij platform plugin template #436

KotlinIsland commented Feb 8, 2022 •

edited

Loading

KotlinIsland commented Feb 8, 2022

koxudaxi commented Feb 8, 2022

KotlinIsland commented Feb 8, 2022 •

edited

Loading

KotlinIsland commented Feb 8, 2022

KotlinIsland Feb 8, 2022

koxudaxi Feb 12, 2022

KotlinIsland Feb 12, 2022

KotlinIsland Feb 9, 2022

koxudaxi Feb 12, 2022

KotlinIsland Feb 9, 2022

codecov bot commented Feb 11, 2022 •

edited

Loading

koxudaxi commented Feb 12, 2022

koxudaxi commented Feb 12, 2022

KotlinIsland commented Feb 12, 2022 •

edited

Loading

koxudaxi commented Feb 12, 2022

KotlinIsland commented Feb 12, 2022

koxudaxi commented Feb 12, 2022

koxudaxi left a comment

koxudaxi commented Feb 12, 2022

KotlinIsland commented Feb 13, 2022

koxudaxi commented Feb 14, 2022

koxudaxi commented Feb 14, 2022

KotlinIsland commented Feb 15, 2022

koxudaxi commented Feb 15, 2022

koxudaxi commented Feb 22, 2022

KotlinIsland commented Feb 23, 2022

		@@ -1,394 +1,7 @@
		<idea-plugin url="https://github.com/koxudaxi/pydantic-pycharm-plugin" require-restart="true">

Refactor project to be more inline with Jetbrains intellij platform plugin template #436

Refactor project to be more inline with Jetbrains intellij platform plugin template #436

Conversation

KotlinIsland commented Feb 8, 2022 • edited Loading

KotlinIsland commented Feb 8, 2022

koxudaxi commented Feb 8, 2022

KotlinIsland commented Feb 8, 2022 • edited Loading

KotlinIsland commented Feb 8, 2022

KotlinIsland Feb 8, 2022

Choose a reason for hiding this comment

koxudaxi Feb 12, 2022

Choose a reason for hiding this comment

KotlinIsland Feb 12, 2022

Choose a reason for hiding this comment

KotlinIsland Feb 9, 2022

Choose a reason for hiding this comment

koxudaxi Feb 12, 2022

Choose a reason for hiding this comment

KotlinIsland Feb 9, 2022

Choose a reason for hiding this comment

codecov bot commented Feb 11, 2022 • edited Loading

Codecov Report

koxudaxi commented Feb 12, 2022

koxudaxi commented Feb 12, 2022

KotlinIsland commented Feb 12, 2022 • edited Loading

koxudaxi commented Feb 12, 2022

KotlinIsland commented Feb 12, 2022

koxudaxi commented Feb 12, 2022

koxudaxi left a comment

Choose a reason for hiding this comment

koxudaxi commented Feb 12, 2022

KotlinIsland commented Feb 13, 2022

koxudaxi commented Feb 14, 2022

koxudaxi commented Feb 14, 2022

KotlinIsland commented Feb 15, 2022

koxudaxi commented Feb 15, 2022

koxudaxi commented Feb 22, 2022

KotlinIsland commented Feb 23, 2022

KotlinIsland commented Feb 8, 2022 •

edited

Loading

KotlinIsland commented Feb 8, 2022 •

edited

Loading

codecov bot commented Feb 11, 2022 •

edited

Loading

KotlinIsland commented Feb 12, 2022 •

edited

Loading