Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#101] Support GHC-8.10 #102

Merged
merged 2 commits into from
May 21, 2020
Merged

[#101] Support GHC-8.10 #102

merged 2 commits into from
May 21, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented May 21, 2020

Resolves #101
Resolves #100
Resolves #98
Resolves #97
Resolves #96

@vrom911 vrom911 added library Choose, move, get rid of libraries build CI (Travis, Windows), build problems with different build tools and different versions refactoring labels May 21, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner May 21, 2020 12:50
@vrom911 vrom911 self-assigned this May 21, 2020
Copy link

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🥇

@@ -142,9 +145,10 @@ resurrect CorpseConfiguration{..} = do

-- TODO: should tomland one day support this?...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I guess we can create an issue in tomland for adding Boolean variable to print lists on each own line. And once this issue is implemented, we should be able to remove most of the logic from here. Do you think it's worth it to support such configuration in tomland?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created: kowainik/tomland#325

@chshersh chshersh merged commit 7f137eb into master May 21, 2020
@chshersh chshersh deleted the vrom911/101-Support-GHC-8.10 branch May 21, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI (Travis, Windows), build problems with different build tools and different versions library Choose, move, get rid of libraries refactoring
Projects
None yet
2 participants