Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed method declarations ( resolves #8157 ) #8158

Closed
wants to merge 1 commit into from

Conversation

ink-splatters
Copy link

This PR fixes #8157 by:

  • declaring new macro for PyCFunctionWithKeywords python type
  • adding missing parameters to methods and fixing corresponding invocations

also, module_methods[] table in kitty/cocoa_window.m was updated to use METHOD* macros

@kovidgoyal
Copy link
Owner

-Wcast-function-type-mismatch is unknown in older clang you need to to
suppress it conditionally based on clang version. And postscript name
for face is used in linux code as well so if you change its signature
you need to change it there as well.

@kovidgoyal
Copy link
Owner

Fixed in master.

@kovidgoyal kovidgoyal closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation errors
2 participants