Low effort port to charset_normalizer #1690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a pure python implementation. The whole point of using cchardet |
|
I have now switched calibre to directly using uchardet, which is what cchardet is an overly elaborate wrapper of. |
kovidgoyal
added a commit
that referenced
this pull request
Jul 16, 2022
cchardet is not maintained anymore: PyYoshi/cChardet#77 cchardet is based on uchardet with the addition of reporting encoding detection confidence. We dont really need that, so moving to uchardet is simplest. See #1690 (Low effort port to charset_normalizer)
|
Thank you, that gets the job done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PyYoshi/cChardet#77
Note that I have not updated
setup/arch-ci.shandbypy/sources.json, as I don't really understand the files.