Implement the experimental pointer lock API #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
koute
reviewed
Jul 3, 2018
src/webapi/events/pointer.rs
Outdated
| impl IEvent for PointerLockChangeEvent {} | ||
| impl IUiEvent for PointerLockChangeEvent {} | ||
| impl IMouseEvent for PointerLockChangeEvent {} | ||
| impl IPointerEvent for PointerLockChangeEvent {} |
There was a problem hiding this comment.
Hmm... I don't think these events are supposed to derive from these? (The specs are somewhat unclear regarding that.)
Taking a peek a Firefox sources it looks like it should just be an Event? Can you double check?
There was a problem hiding this comment.
...Huh. That's what I get for not checking my assumptions about web api's I guess. Yeah those derivations shouldn't be there.
|
Also it'd be nice if you could add a few really basic tests just as we have for other events. (: |
|
Sure, no problem. |
|
You also should export those events in |
|
Whoops! My bad. |
|
LGTM; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.