ring: fix location mode subscriptions #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leedsalex
commented
Mar 20, 2023
|
|
||
| // if the location has a base station, updates when arming/disarming are not sent to the `onLocationMode` subscription | ||
| // instead we subscribe to the security panel, which is updated during arming actions | ||
| this.location.getSecurityPanel().then(panel => { | ||
| panel.onData.subscribe(_ => { | ||
| this.location.getLocationMode().then(response => { | ||
| this.updateLocationMode(response.mode); |
There was a problem hiding this comment.
updateLocationMode call no needed, as it's subscribed to on the line above
leedsalex
commented
Mar 20, 2023
Comment on lines
-182
to
-184
| if (!this.securitySystemState) { | ||
| this.updateLocationMode('disabled'); | ||
| } |
There was a problem hiding this comment.
couldn't find a case when this was needed, if the idea is to initialize the securitySystemState I can add that before all the subscription logic
leedsalex
commented
Mar 20, 2023
| this.location = location; | ||
|
|
||
| this.location.onLocationMode.subscribe(this.updateLocationMode); | ||
| this.location.onLocationMode.subscribe(mode => this.updateLocationMode(mode)); |
There was a problem hiding this comment.
this was causing an actual error, I guess function passing doesn't work as I expected in typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fix for probing the devices on startup is in this pr too.