Reolink add nvr flag #1620
Merged
Reolink add nvr flag #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koush
reviewed
Oct 21, 2024
| const deviceInfo: DevInfo = await response.body?.[0]?.value?.DevInfo; | ||
|
|
||
| // Will need to check if it's valid for NVR and NVR_WIFI | ||
| if (['HOMEHUB'].includes(deviceInfo.exactType)) { |
There was a problem hiding this comment.
invert this logic so if it doesn't include, it immediately returns deviceInfo. Remaining code will be only for reolink home hub logic.
koush
reviewed
Oct 21, 2024
plugins/reolink/src/reolink-api.ts
Outdated
| @@ -201,16 +201,53 @@ export class ReolinkCameraClient { | |||
| const url = new URL(`http://${this.host}/api.cgi`); | |||
| const params = url.searchParams; | |||
| params.set('cmd', 'GetDevInfo'); | |||
| const response = await this.requestWithLogin({ | |||
| let response = await this.requestWithLogin({ | |||
There was a problem hiding this comment.
why are these "let" and reused?
Use different variables for different request types. mutability on the response makes understanding this code later difficult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.