Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: add TTYSettings #1540

Merged
merged 2 commits into from
Aug 5, 2024
Merged

sdk: add TTYSettings #1540

merged 2 commits into from
Aug 5, 2024

Conversation

bjia56
Copy link
Collaborator

@bjia56 bjia56 commented Aug 3, 2024

Intended to be used by btop plugin to add the path where btop is installed to the interactive terminal.

@bjia56
Copy link
Collaborator Author

bjia56 commented Aug 3, 2024

Another possible implementation is to expose only one function, getTerminalSettings, and have that return a list (similar to the existing getSettings), where some list items may be labeled as "PATH"

@koush
Copy link
Owner

koush commented Aug 4, 2024

should return something like

getTerminalSettings(): Promise<{
  paths?: string[];
}>;

@koush
Copy link
Owner

koush commented Aug 4, 2024

Should maybe all be called TTYSettings per the existing TTY interface?

@bjia56 bjia56 changed the title sdk: add TerminalSettings sdk: add TTYSettings Aug 5, 2024
@koush koush merged commit 2569e7c into koush:main Aug 5, 2024
1 check passed
@bjia56 bjia56 deleted the sdk-terminalsettings branch August 5, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants