reolink: add siren support #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koush
reviewed
Jun 23, 2024
plugins/reolink/src/main.ts
Outdated
| @@ -521,6 +596,7 @@ class ReolinkProvider extends RtspProvider { | |||
| ScryptedInterface.Camera, | |||
| ScryptedInterface.AudioSensor, | |||
| ScryptedInterface.MotionSensor, | |||
| ScryptedInterface.DeviceProvider, | |||
There was a problem hiding this comment.
don't add this interface unless it has a siren.
There was a problem hiding this comment.
Got it. Updated to push the DeviceProvider interface when the siren ability is determined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the camera to be a DeviceProvider, so that a Siren device can be provided by the camera if siren mode is supported. Siren support is inferred via the GetAbility API.
For my PoE doorbell, I noticed that the alarm_mode = "manul" won't trigger the siren. Using the siren's timed mode instead and pumping the API is a workaround.