Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add Python REPL support + introduce optional requirements.txt #1360

Merged
merged 9 commits into from
Mar 6, 2024

Conversation

bjia56
Copy link
Collaborator

@bjia56 bjia56 commented Mar 5, 2024

Introduces ptpython as a remote REPL for Python plugins. Works with existing REPL plumbing.

Dependency tree of ptpython:

$ johnnydep --verbose=0 ptpython
name                               summary
---------------------------------  -------------------------------------------------------------------------------------------------
ptpython                           Python REPL build on top of prompt_toolkit
├── appdirs                        A small Python module for determining appropriate platform-specific dirs, e.g. a "user data dir".
├── jedi>=0.16.0                   An autocompletion tool for Python that can be used for text editors.
│   └── parso<0.9.0,>=0.8.3        A Python Parser
├── prompt-toolkit<3.1.0,>=3.0.34  Library for building powerful interactive command lines in Python
│   └── wcwidth                    Measures the displayed width of unicode strings in a terminal
└── pygments                       Pygments is a syntax highlighting package written in Python.

@bjia56 bjia56 changed the title server: add Python REPL support server: add Python REPL support + introduce system requirements.txt Mar 5, 2024
@koush
Copy link
Owner

koush commented Mar 5, 2024

does python have optional dependencies? was thinking that maybe the pip install can be a separate requirements file that we can ignore the failure. so 2 pip installs.

@bjia56
Copy link
Collaborator Author

bjia56 commented Mar 6, 2024

There might be, I'd have to check. Though, I'm a bit hesitant to recommend splitting out into two requirements files since having one allows pip to resolve dependency constraints. If there are two, then I believe the second file will take precedence.

@bjia56 bjia56 changed the title server: add Python REPL support + introduce system requirements.txt server: add Python REPL support + introduce optional requirements.txt Mar 6, 2024
@koush koush merged commit 71ce995 into koush:main Mar 6, 2024
@bjia56 bjia56 deleted the python-console branch March 6, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants