client, server, core: Add StreamService interface and TerminalService device #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bjia56
commented
Nov 11, 2023
bjia56
commented
- Add a new StreamService interface to connect bidirectional streams with AsyncGenerators
- Add a new TerminalService device to core plugin to replace existing server shell functionality
- Update client, ui to use new TerminalService device over connectRPCObject
koush
reviewed
Nov 11, 2023
koush
reviewed
Nov 11, 2023
koush
reviewed
Nov 11, 2023
koush
reviewed
Nov 11, 2023
…e connection teardown" This reverts commit 1b3c283.
koush
reviewed
Nov 13, 2023
plugins/core/src/terminal-service.ts
Outdated
| } | ||
| } | ||
|
|
||
| setTimeout(async () => { |
There was a problem hiding this comment.
I think I had this setTimeout pattern before due to some weird issue with the event loop on engine.io. I think this can be replaced with an in place
(async() => {
... code
})()
koush
reviewed
Nov 13, 2023
koush
reviewed
Nov 13, 2023
|
looking good! had a few remaining questions, and remembered that all errors need be caught in the unmonitored promise inside the setTiemout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.