server, client: connectRPCObject for web api clients #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koush
reviewed
Nov 6, 2023
koush
reviewed
Nov 6, 2023
koush
reviewed
Nov 6, 2023
koush
reviewed
Nov 6, 2023
|
uhh disregard that change, didn't realize I was working in your branch. |
koush
force-pushed
the
connect-object-web
branch
from
4292254 to
a50dda8
Compare
|
ok backed it out with a force push, pretty sure this was the state before I clobbered your stuff. |
koush
reviewed
Nov 7, 2023
koush
reviewed
Nov 7, 2023
koush
reviewed
Nov 7, 2023
koush
reviewed
Nov 7, 2023
koush
reviewed
Nov 8, 2023
| * Handle incoming connections that will be | ||
| * proxied to a connectRPCObject socket. | ||
| */ | ||
| export function setupConnectRPCObjectProxy(clusterSecret: string, port: number, connection: Socket & IOSocket) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a new engine.io endpoint to serve as the transport for connectRPCObject requests coming from the web client.