core: replace google maps with leaflet/OSM #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a huge diff in package-lock.json, probably because I deleted and recreated it. Let me see if I can reduce the diff by restoring the old one. |
|
As discussed in Discord, the package-lock.json is ok to delete and recreate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Maps requires an API key and allow-listing of referrer urls, which causes the PositionSensor map display to not work for most domains/IPs. This change replaces it with Leaflet, using OpenStreetMap underneath.
Also adds a couple of babel dev dependencies since they were removed from the core babel plugin, which prevents a clean rebuild of the UI from working.