hap: fix camera init without sensor (#639)

koush · Mar 18, 2023 · a520357 · a520357
1 parent 21eeab6
commit a520357
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/.gitmodules b/.gitmodules
@@ -1,6 +1,3 @@
-[submodule "plugins/homekit/HAP-NodeJS"]
-	path = external/HAP-NodeJS
-	url = ../../koush/HAP-NodeJS
 [submodule "plugins/unifi-protect/src/unifi-protect"]
 	path = external/unifi-protect
 	url = ../../koush/unifi-protect.git

diff --git a/external/HAP-NodeJS b/external/HAP-NodeJS
diff --git a/plugins/homekit/package-lock.json b/plugins/homekit/package-lock.json
diff --git a/plugins/homekit/package.json b/plugins/homekit/package.json
@@ -1,6 +1,6 @@
 {
    "name": "@scrypted/homekit",
-   "version": "1.2.16",
+   "version": "1.2.17",
    "description": "HomeKit Plugin for Scrypted",
    "scripts": {
       "scrypted-setup-project": "scrypted-setup-project",

diff --git a/plugins/homekit/src/types/camera.ts b/plugins/homekit/src/types/camera.ts
@@ -98,12 +98,13 @@ addSupportedType({
         const detectAudio = storage.getItem('detectAudio') === 'true';
         const needAudioMotionService = device.interfaces.includes(ScryptedInterface.AudioSensor) && detectAudio;
         const linkedMotionSensor = storage.getItem('linkedMotionSensor');
+        const isRecordingEnabled = !!linkedMotionSensor || device.interfaces.includes(ScryptedInterface.MotionSensor) || needAudioMotionService
 
         const storageKeySelectedRecordingConfiguration = 'selectedRecordingConfiguration';
 
         let configuration: CameraRecordingConfiguration;
         const openRecordingStreams = new Map<number, Deferred<any>>();
-        if (linkedMotionSensor || device.interfaces.includes(ScryptedInterface.MotionSensor) || needAudioMotionService) {
+        if (isRecordingEnabled) {
             recordingDelegate = {
                 updateRecordingConfiguration(newConfiguration: CameraRecordingConfiguration ) {
                     configuration = newConfiguration;
@@ -193,12 +194,12 @@ addSupportedType({
             cameraStreamCount: 8,
             delegate,
             streamingOptions,
-            recording: {
+            recording: !isRecordingEnabled ? undefined : {
                 options: recordingOptions,
                 delegate: recordingDelegate,
             },
             sensors: {
-                motion: true,
+                motion: isRecordingEnabled,
             },
         });