Add Java support #14
Merged
Add Java support #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
kou
reviewed
Jul 31, 2023
| @@ -58,6 +58,8 @@ public static FlightMethod fromProtocol(final String methodName) { | |||
| return LIST_ACTIONS; | |||
| } else if (FlightServiceGrpc.getDoExchangeMethod().getFullMethodName().equals(methodName)) { | |||
| return DO_EXCHANGE; | |||
| } else if (FlightServiceGrpc.getPollFlightInfoMethod().getFullMethodName().equals(methodName)) { | |||
| return DO_EXCHANGE; | |||
There was a problem hiding this comment.
Changed in the original PR: apache@9fb0af3
Comment on lines
+66
to
+69
| default RetryInfo pollFlightInfo(CallContext context, FlightDescriptor descriptor) { | ||
| FlightInfo info = getFlightInfo(context, descriptor); | ||
| return new RetryInfo(info, null, null, null); | ||
| } |
There was a problem hiding this comment.
Ah, we can use GetFlightInfo() as the default PollFlightInfo() implementation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.