Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VisUI Request] Set text orientation in VisImageTextButton #373

Closed
bploeckelman opened this issue Dec 6, 2022 · 1 comment
Closed

[VisUI Request] Set text orientation in VisImageTextButton #373

bploeckelman opened this issue Dec 6, 2022 · 1 comment
Assignees
@bploeckelman @czyzby
Labels
enhancement ui

Comments

@bploeckelman
Copy link
Contributor

It would be helpful to have something like a textAlignment property in VisImageTextButton that positions the text label relative to the image in the button table.

Defaulting the value to right would match the existing behavior but if it's set to top or bottom the label would be placed on a separate row above or below the image, and if it's set to left then the label would be added to the button table first, followed by the image.
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 10, 2022
@bploeckelman
Adds 'orientation' parameter to VisImageTextButton to allow different…
e4c2b36 
… positions of label relative to image (kotcrab#373)
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 10, 2022
@bploeckelman
Adds test for VisImageTextButton orientations (kotcrab#373)
0414dfa
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 10, 2022
@bploeckelman
Adds 'orientation' parameter to VisImageTextButton to allow different…
77a07f3 
… positions of label relative to image (kotcrab#373)
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 10, 2022
@bploeckelman
Adds test for VisImageTextButton orientations (kotcrab#373)
0bf057e
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 11, 2022
@bploeckelman
Setting VisImageTextButton orientation only updates actors, not liste…
5e1d829 
…ners (kotcrab#373)
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 11, 2022
@bploeckelman
Update CHANGES kotcrab#373
56a2a08
czyzby pushed a commit that referenced this issue Dec 11, 2022
@bploeckelman
Add VisImageTextButton orientation parameter (#373)
80d1297 
* Adds 'orientation' parameter to VisImageTextButton to allow different positions of label relative to image (#373)

* Adds test for VisImageTextButton orientations (#373)

* Setting VisImageTextButton orientation only updates actors, not listeners (#373)

* Changes VisImageTextButton Orientation enum constants to uppercase

* Update CONTRIBUTORS

* Update CHANGES #373
@czyzby
Copy link
Collaborator

czyzby commented Dec 11, 2022

Thanks for implementing this feature, @bploeckelman!

@czyzby czyzby closed this as completed Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bploeckelman bploeckelman

@czyzby czyzby

Labels
enhancement ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bploeckelman @czyzby