Switch from winapi to windows-rs #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotauskas
requested changes
Nov 13, 2023
There was a problem hiding this comment.
I'm not the biggest fan of the handle transmutes everywhere. src/os/windows/mod.rs would be a good place to put a function that converts BorrowedHandle<'_> to windows-rs's abysmal HANDLE type. (Also, that don't even need to be a transmute, the isize field is public and the standard library RawHandle type is a pointer, meaning that it can be casted to isize.)
ncihnegn
force-pushed
the
windows-rs
branch
2 times, most recently
from
c6261ae to
b4b086d
Compare
|
Added helpers for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43.