Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support kotlin.AutoCloseable in addition to (instead of) ScopeCloseable #463

Closed
Nek-12 opened this issue Jan 4, 2025 · 2 comments
Closed

Support kotlin.AutoCloseable in addition to (instead of) ScopeCloseable #463

Nek-12 opened this issue Jan 4, 2025 · 2 comments

Comments

@Nek-12
Copy link

Nek-12 commented Jan 4, 2025

ScopeCloseable has the exact same signature as the AutoCloseable. We could migrate it to a typealias or at least let the ScopeCloseable implement the AutoCloseable to allow universal syntax.
romainbsl added a commit that referenced this issue Jan 7, 2025
@romainbsl
refactor(#463): deprecate ScopeCloseable in benefit of kotlin AutoClo…
d65fe55 
…seable
romainbsl added a commit that referenced this issue Jan 7, 2025
@romainbsl
refactor(#463): deprecate ScopeCloseable in benefit of kotlin AutoClo…
97ad91c 
…seable
romainbsl added a commit that referenced this issue Jan 7, 2025
@romainbsl
refactor(#463): deprecate ScopeCloseable in benefit of kotlin AutoClo…
0da9928 
…seable
romainbsl added a commit that referenced this issue Jan 7, 2025
@romainbsl
docs(#463): update docs to reference the use of kotlin AutoCloseable
0988062
@romainbsl
Copy link
Member

Done in https://github.com/kosi-libs/Kodein/releases/tag/v7.24.0

@Nek-12
Copy link
Author

Nek-12 commented Jan 7, 2025

Thank you so much for quick work on that one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romainbsl @Nek-12