Publish artifacts on release branches #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI was supposed to publish artifacts on the main branch and on release branches. However, I misread the documentation for the `contains(search, item)` expression. I expected that search is the value to search for, while item is the thing to search in. It is actually the other way around: search is the thing to search in, and item is what is searched for. In addition, contains might not be explicit enough. So for safeguarding it may be better to use `startsWith(searchString, searchValue)`. This function 'Returns true when searchString starts with searchValue'. This problem should now be resolved.
korthout
added
the
backport release-v1.3
|
It's seems the backport workflow is skipped for this pull request, even though the workflow triggers on: on:
pull_request_target:
types: [closed]
issue_comment:
types: [created]
EDIT: The reason is that this workflow does not use a PAT for the backport action, so the GITHUB_TOKEN is used which cannot trigger any other workflows. I'll trigger the backport manually then: /backport |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI was supposed to publish artifacts on the main branch and on release branches. However, I misread the documentation for the
contains(search, item)expression. I expected that search is the value to search for, while item is the thing to search in. It is actually the other way around: search is the thing to search in, and item is what is searched for.In addition, contains might not be explicit enough. So for safeguarding it may be better to use
startsWith(searchString, searchValue). This function 'Returns true when searchString starts with searchValue'.This problem should now be resolved.
We also need to backport this to v1.3 where the problem also exists. Before that release, there was no automated packaging and publishing of artifacts yet, so there is no need to backport it further down.