Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: korge crashing after too many sounds are played on linux #1747

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

cmhulbert
Copy link
Contributor

Code mostly provided by @soywiz, with minor modifications of my own. Thank you!
Closes #1728

@soywiz soywiz changed the title fix: korge crashing after too many sounds are played fix: korge crashing after too many sounds are played on linux Jul 1, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (2552220) 51.09% compared to head (e7fa75c) 51.09%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
- Coverage   51.09%   51.09%   -0.01%     
==========================================
  Files        1736     1736              
  Lines      101972   101981       +9     
  Branches    14460    14460              
==========================================
- Hits        52106    52104       -2     
- Misses      45889    45898       +9     
- Partials     3977     3979       +2     
Flag Coverage Δ
unittests 51.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onMain/kotlin/korlibs/audio/sound/backends/ALSA.kt 6.18% <0.00%> (-0.64%) ⬇️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 1640d4e into korlibs:main Jul 1, 2023
@soywiz
Copy link
Member

soywiz commented Jul 1, 2023

Thanks!

@cmhulbert cmhulbert deleted the fix/ALSA branch July 5, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when attempting to play sounds repeatedly on JVM with ALSA
3 participants