Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize image decoding on MacOS JVM by using CoreGraphics decoder #1709

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 16, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 15.74% and project coverage change: -0.03 ⚠️

Comparison is base (e2081e0) 50.98% compared to head (0bfae0f) 50.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
- Coverage   50.98%   50.95%   -0.03%     
==========================================
  Files        1726     1727       +1     
  Lines      100821   100927     +106     
  Branches    14327    14333       +6     
==========================================
+ Hits        51402    51431      +29     
- Misses      45479    45575      +96     
+ Partials     3940     3921      -19     
Flag Coverage Δ
unittests 50.95% <15.74%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ck/src/commonMain/kotlin/korlibs/time/Stopwatch.kt 78.94% <0.00%> (-4.39%) ⬇️
...vmMain/kotlin/korlibs/render/platform/NativeKgl.kt 0.00% <0.00%> (ø)
...bs/image/format/CoreGraphicsImageFormatProvider.kt 0.00% <0.00%> (ø)
.../jvmMain/kotlin/korlibs/io/file/std/LocalVfsJvm.kt 37.96% <ø> (ø)
...rlibs/image/format/NativeImageFormatProviderJvm.kt 58.97% <27.77%> (-31.51%) ⬇️
...jvmMain/kotlin/korlibs/image/awt/AwtNativeImage.kt 59.37% <63.15%> (-0.47%) ⬇️
.../src/commonMain/kotlin/korlibs/image/color/BGRA.kt 100.00% <100.00%> (+10.00%) ⬆️
...rim/src/jvmMain/kotlin/korlibs/image/awt/AwtExt.kt 44.44% <100.00%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit d744d2d into main Jun 16, 2023
@soywiz soywiz deleted the optimize/optimize.image.decoding.on.macos.jvm branch October 4, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants