Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uniform arrays in uniform blocks #1691

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 13, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 77.52% and project coverage change: -0.01 ⚠️

Comparison is base (c37453a) 50.99% compared to head (047fca5) 50.99%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
- Coverage   50.99%   50.99%   -0.01%     
==========================================
  Files        1725     1725              
  Lines      100669   100734      +65     
  Branches    14306    14310       +4     
==========================================
+ Hits        51337    51369      +32     
- Misses      45417    45429      +12     
- Partials     3915     3936      +21     
Flag Coverage Δ
unittests 50.99% <77.52%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/commonMain/kotlin/korlibs/math/geom/Vector3.kt 41.26% <0.00%> (-0.67%) ⬇️
...ain/kotlin/korlibs/graphics/shader/UniformBlock.kt 67.27% <64.81%> (-2.66%) ⬇️
...commonMain/kotlin/korlibs/memory/dyn/KStructure.kt 34.48% <100.00%> (+0.56%) ⬆️
korgw/src/commonMain/kotlin/korlibs/graphics/AG.kt 46.42% <100.00%> (+4.12%) ⬆️
...kotlin/korlibs/graphics/shader/gl/GlslGenerator.kt 68.18% <100.00%> (+1.20%) ⬆️
...mmonMain/kotlin/korlibs/graphics/shader/shaders.kt 62.42% <100.00%> (+0.05%) ⬆️
...Test/kotlin/korlibs/graphics/AGUniformBlockTest.kt 100.00% <100.00%> (ø)
...src/commonMain/kotlin/korlibs/math/geom/Vector4.kt 38.59% <100.00%> (+1.09%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 1c87fda into main Jun 13, 2023
@soywiz soywiz deleted the feature/support.uniform.arrays.in.uniform.blocks branch October 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants