Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ImageAnimationView & ImageDataView Anchorable. Adds PixelAnchorable #1683

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 11, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 35.71% and project coverage change: -0.02 ⚠️

Comparison is base (62b7049) 50.71% compared to head (96d98f4) 50.69%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
- Coverage   50.71%   50.69%   -0.02%     
==========================================
  Files        1717     1717              
  Lines      100573   100585      +12     
  Branches    14290    14290              
==========================================
- Hits        51001    50992       -9     
- Misses      45654    45669      +15     
- Partials     3918     3924       +6     
Flag Coverage Δ
unittests 50.69% <35.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...commonMain/kotlin/korlibs/korge/view/Anchorable.kt 37.50% <0.00%> (-5.36%) ⬇️
...tlin/korlibs/korge/view/animation/ImageDataView.kt 0.00% <0.00%> (ø)
...korlibs/korge/view/animation/ImageAnimationView.kt 44.03% <55.55%> (-4.99%) ⬇️

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jobe-m
Copy link
Member

jobe-m commented Jun 11, 2023

Does pixelAnchor mean I can set the anchor point in pixels? Should come in handy, I think :)

@soywiz
Copy link
Member Author

soywiz commented Jun 11, 2023

Yes. To have an stable anchoring in the case the children change. Used it here: https://github.com/korlibs/korge-starter-kit-dungeon

@soywiz soywiz merged commit 818747b into main Jun 12, 2023
@soywiz soywiz deleted the feature/ImageDataView.ImageAnimationView.anchorable branch October 4, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants