Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM Browser support for all the libraries including korgw and korge (DISABLED) #1626

Merged
merged 15 commits into from
May 24, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented May 23, 2023

Retake on fixing stuff here: #1628

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Patch coverage: 4.76% and project coverage change: -0.02 ⚠️

Comparison is base (a938d67) 51.10% compared to head (dc04a50) 51.08%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1626      +/-   ##
==========================================
- Coverage   51.10%   51.08%   -0.02%     
==========================================
  Files        1680     1680              
  Lines       99254    99271      +17     
  Branches    14176    14176              
==========================================
- Hits        50720    50713       -7     
- Misses      44638    44663      +25     
+ Partials     3896     3895       -1     
Flag Coverage Δ
unittests 51.08% <4.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...libs/korge/gradle/targets/android/AndroidDirect.kt 0.00% <0.00%> (ø)
.../src/main/kotlin/korlibs/root/RootKorlibsPlugin.kt 0.00% <0.00%> (ø)
korge/src/commonMain/kotlin/korlibs/korge/Korge.kt 54.83% <0.00%> (ø)
.../commonMain/kotlin/korlibs/korge/view/BlendMode.kt 81.66% <50.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz changed the title WASM support for korgw and korge WASM Browser support for all the libraries including korgw and korge May 24, 2023
@soywiz soywiz enabled auto-merge (squash) May 24, 2023 00:45
@soywiz soywiz changed the title WASM Browser support for all the libraries including korgw and korge WASM Browser support for all the libraries including korgw and korge (DISABLED) May 24, 2023
@soywiz soywiz merged commit 67c1bc6 into main May 24, 2023
@soywiz soywiz deleted the feature/wasm.korgw.and.korge branch October 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants