Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes new esbuild version on windows #1611

Merged
merged 2 commits into from
May 21, 2023
Merged

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented May 21, 2023

Fixes #1610
Noticed on #1580

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (e2170a0) 51.08% compared to head (fc44bd1) 51.13%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
+ Coverage   51.08%   51.13%   +0.04%     
==========================================
  Files        1678     1678              
  Lines       99272    99192      -80     
  Branches    14168    14159       -9     
==========================================
+ Hits        50714    50719       +5     
+ Misses      44686    44604      -82     
+ Partials     3872     3869       -3     
Flag Coverage Δ
unittests 51.13% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../kotlin/korlibs/korge/gradle/targets/js/Esbuild.kt 0.00% <0.00%> (ø)
.../src/main/kotlin/korlibs/root/RootKorlibsPlugin.kt 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit fb96235 into main May 21, 2023
@soywiz soywiz deleted the fix/fix.esbuild.on.windows branch October 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execution failed for task ':korge:browserReleaseEsbuild' when attempting to runJs
2 participants