Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas texture generation for *.atlas folder/files, fixes catalog generation and resource processing on all the targets & adds mechanism to add a custom resource processors in the build.gradle #1565

Merged
merged 11 commits into from
May 2, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented May 2, 2023

No description provided.

@soywiz soywiz force-pushed the feature/new.bin.packer branch from fd4d1c5 to 973568a Compare May 2, 2023 03:28
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch coverage: 0.12% and project coverage change: -0.43 ⚠️

Comparison is base (24139cf) 51.64% compared to head (4940f12) 51.21%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
- Coverage   51.64%   51.21%   -0.43%     
==========================================
  Files        1669     1672       +3     
  Lines       98110    98741     +631     
  Branches    13949    14117     +168     
==========================================
- Hits        50666    50571      -95     
- Misses      43566    44298     +732     
+ Partials     3878     3872       -6     
Flag Coverage Δ
unittests 51.21% <0.12%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tlin/korlibs/korge/gradle/KorgeProcessResources.kt 1.29% <0.00%> (+1.29%) ⬆️
...korlibs/korge/gradle/processor/CatalogGenerator.kt 0.00% <0.00%> (ø)
...s/korge/gradle/processor/KorgeResourceProcessor.kt 0.00% <0.00%> (ø)
...rlibs/korge/gradle/processor/KorgeTexturePacker.kt 0.00% <0.00%> (ø)
...libs/korge/gradle/targets/android/AndroidDirect.kt 0.00% <0.00%> (ø)
...in/korlibs/korge/gradle/targets/desktop/Desktop.kt 0.00% <0.00%> (ø)
...ain/kotlin/korlibs/korge/gradle/targets/ios/Ios.kt 0.00% <0.00%> (ø)
.../kotlin/korlibs/korge/gradle/targets/js/Esbuild.kt 0.00% <0.00%> (ø)
...lin/korlibs/korge/gradle/texpacker/NewBinPacker.kt 0.00% <0.00%> (ø)
...korlibs/korge/gradle/texpacker/NewTexturePacker.kt 0.00% <0.00%> (ø)
... and 3 more

... and 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz changed the title Atlas texture generation for *.atlas folder/files & fix catalog generation Atlas texture generation for *.atlas folder/files, fixes catalog generation and resource processing on all the targets & adds mechanism to add a custom resource processors in the build.gradle May 2, 2023
@soywiz soywiz enabled auto-merge (squash) May 2, 2023 06:26
@soywiz soywiz disabled auto-merge May 2, 2023 06:51
@soywiz soywiz enabled auto-merge (squash) May 2, 2023 07:15
@jobe-m
Copy link
Member

jobe-m commented May 2, 2023

This looks very promising. Will it be possible to use Aseprite files as input for this atlas generation at gradle time?
If not, maybe we can generate an atlas file out from Aseprite meta data.

@soywiz soywiz merged commit a1c2305 into main May 2, 2023
@soywiz
Copy link
Member Author

soywiz commented May 2, 2023

@jobe-m

We had some problems with the classpath because we included the current korge libraries and compiled the jvm target of the current project to detect new plugins. To avoid some issues I disabled that for now and we dont have access to korim/korio anymore in the plugin, so loading ase files with korim in the plugin is not possible anymore.

We can try to enable it again in >= 4.1 to support loading psd, qoi and ase files too for atlas generation in the plugin by using korim.

Feel free to open a feature request for that 👍

@jobe-m
Copy link
Member

jobe-m commented May 2, 2023

I created #1566

@soywiz soywiz deleted the feature/new.bin.packer branch October 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants