Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runJs: correct MIME type for wasm files #1562

Merged
merged 1 commit into from
May 1, 2023
Merged

runJs: correct MIME type for wasm files #1562

merged 1 commit into from
May 1, 2023

Conversation

smaugfm
Copy link
Contributor

@smaugfm smaugfm commented May 1, 2023

Currently wasm files are served with application/octet-stream by the builtin staticHttpServer task used in runJs which causes browser error, i.e. with WebAssembly.instantiateStreaming.
I understand that wasm is not supported by Korge yet, but it can still be used in source-sets independent from Korge, i.e. to offload heavy game computations.

Verified

This commit was signed with the committer’s verified signature.
kuba2k2 Kuba Szczodrzyński
Currently wasm files are served with `application/octet-stream` which is not working.
I understand that wasm is not supported by Korge yet, but it can still be used i.e. to offload heavy game computations.
@soywiz soywiz merged commit 18e40bb into korlibs:main May 1, 2023
@soywiz
Copy link
Member

soywiz commented May 1, 2023

Thanks!

@smaugfm
Copy link
Contributor Author

smaugfm commented May 1, 2023

Any chance for this to come up in a future 4.0.0 release candidate?

@soywiz
Copy link
Member

soywiz commented May 1, 2023

This will be included in 4.0.0 final. That will be released next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants