Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes characters from being slightly displaced and spaces showing a dot in a LazyBitmapFont #1223

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jan 26, 2023

Fixes #1207

@codecov-commenter
Copy link

Codecov Report

Base: 53.60% // Head: 53.64% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (22b12d4) compared to base (c8f7b34).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 22b12d4 differs from pull request most recent head 47d810c. Consider uploading reports for the commit 47d810c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
+ Coverage   53.60%   53.64%   +0.03%     
==========================================
  Files        1826     1827       +1     
  Lines      122049   122181     +132     
  Branches    18956    18978      +22     
==========================================
+ Hits        65429    65542     +113     
+ Misses      51400    51399       -1     
- Partials     5220     5240      +20     
Flag Coverage Δ
unittests 53.64% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/kotlin/com/soywiz/korim/font/LazyBitmapFont.kt 81.08% <100.00%> (ø)
...kotlin/com/soywiz/korim/font/LazyBitmapFontTest.kt 100.00% <100.00%> (ø)
...ck/src/commonMain/kotlin/com/soywiz/klock/Sleep.kt 0.00% <0.00%> (-50.00%) ⬇️
...e/src/commonTest/kotlin/com/soywiz/korge3d/test.kt 75.00% <0.00%> (-25.00%) ⬇️
.../commonTest/kotlin/com/soywiz/korau/mod/MODTest.kt 75.00% <0.00%> (-25.00%) ⬇️
...mmonTest/kotlin/com/soywiz/korio/vfs/IsoVfsTest.kt 77.77% <0.00%> (-11.12%) ⬇️
...st/kotlin/com/soywiz/korio/vfs/ResourcesVfsTest.kt 81.81% <0.00%> (-9.10%) ⬇️
...com/soywiz/korim/text/RichTextDataPlacementTest.kt 75.00% <0.00%> (-8.34%) ⬇️
...ommonTest/kotlin/com/soywiz/korge3d/ColladaTest.kt 89.18% <0.00%> (-8.11%) ⬇️
...tlin/com/soywiz/korio/net/AsyncClientServerTest.kt 74.35% <0.00%> (-7.70%) ⬇️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz force-pushed the fix/fixes.space.showing.a.dot branch from 47d810c to 3092a4d Compare January 26, 2023 21:17
@soywiz soywiz merged commit ec2697f into main Jan 26, 2023
@soywiz soywiz deleted the fix/fixes.space.showing.a.dot branch October 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space in bitmap font is not blank
2 participants