Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build.gradle*.kts code into buildSrc #1202

Merged
merged 8 commits into from
Jan 24, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jan 23, 2023

This puts all the code in the same place, so we can later refactor, try to find repeated code and unify etc.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Base: 54.12% // Head: 53.62% // Decreases project coverage by -0.51% ⚠️

Coverage data is based on head (c16010b) compared to base (7d48ff3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   54.12%   53.62%   -0.51%     
==========================================
  Files        1822     1826       +4     
  Lines      120885   122049    +1164     
  Branches    18683    18968     +285     
==========================================
+ Hits        65430    65447      +17     
- Misses      50238    51397    +1159     
+ Partials     5217     5205      -12     
Flag Coverage Δ
unittests 53.62% <0.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oywiz/korge/gradle/targets/desktop/DesktopCross.kt 0.00% <0.00%> (ø)
...tlin/com/soywiz/korge/gradle/targets/ios/IosSdk.kt 0.00% <0.00%> (ø)
...com/soywiz/korge/gradle/targets/ios/IosXcodegen.kt 0.00% <0.00%> (ø)
...main/kotlin/com/soywiz/korge/gradle/util/DslExt.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/com/soywiz/korge/gradle/util/Dyn.kt 0.00% <0.00%> (ø)
...om/soywiz/korge/gradle/util/KorgeReloadNotifier.kt 0.00% <ø> (ø)
...n/kotlin/com/soywiz/korlibs/root/ConfigureKover.kt 0.00% <0.00%> (ø)
...otlin/com/soywiz/korlibs/root/RootKorlibsPlugin.kt 0.00% <0.00%> (ø)
...ildSrc/src/main/kotlin/com/soywiz/korlibs/tools.kt 0.00% <0.00%> (ø)
...mmonTest/kotlin/com/soywiz/korio/vfs/IsoVfsTest.kt 77.77% <0.00%> (-11.12%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit bd85a64 into main Jan 24, 2023
@soywiz soywiz deleted the cleanup/move.build.gradle.code.to.buildSrc branch October 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants