Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes DirectGL on win32 and enable it, since it was not enabled #1198

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jan 19, 2023

Before:

before-win32-directgl

After:

after-win32-directgl

@codecov-commenter
Copy link

Codecov Report

Base: 54.12% // Head: 54.12% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4475f7b) compared to base (67c38ab).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1198   +/-   ##
=======================================
  Coverage   54.12%   54.12%           
=======================================
  Files        1822     1822           
  Lines      121315   121322    +7     
  Branches    18693    18692    -1     
=======================================
+ Hits        65662    65666    +4     
- Misses      50419    50426    +7     
+ Partials     5234     5230    -4     
Flag Coverage Δ
unittests 54.12% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mMain/kotlin/com/soywiz/kgl/KmlGlContextDefault.kt 0.00% <0.00%> (ø)
...Main/kotlin/com/soywiz/korgw/platform/INativeGL.kt 0.00% <0.00%> (ø)
...vmMain/kotlin/com/soywiz/korgw/win32/Win32Tools.kt 0.00% <0.00%> (ø)
.../commonTest/kotlin/com/soywiz/korau/mod/MODTest.kt 75.00% <0.00%> (-25.00%) ⬇️
...com/soywiz/korim/text/RichTextDataPlacementTest.kt 75.00% <0.00%> (-8.34%) ⬇️
...n/com/soywiz/korge/atlas/AtlasResourceProcessor.kt 77.77% <0.00%> (-5.56%) ⬇️
...ommonTest/kotlin/com/soywiz/korge3d/ColladaTest.kt 91.89% <0.00%> (-5.41%) ⬇️
...tlin/com/soywiz/korio/net/AsyncClientServerTest.kt 74.35% <0.00%> (-5.13%) ⬇️
...lin/com.soywiz.korau.sound/SoundAudioStreamTest.kt 78.57% <0.00%> (-3.58%) ⬇️
...mmonTest/kotlin/com/soywiz/korio/vfs/ZipVfsTest.kt 85.71% <0.00%> (-3.30%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit ccbb98e into main Jan 19, 2023
@soywiz soywiz deleted the fix/fix.direct.gl.on.win32.and.enable.it branch October 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants