Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kotlin 1.8.0 #1123

Merged
merged 13 commits into from
Dec 28, 2022
Merged

Update to Kotlin 1.8.0 #1123

merged 13 commits into from
Dec 28, 2022

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Nov 22, 2022

No plans to merge, but let's see if the code is still compiling

Related issue:

@soywiz soywiz force-pushed the soywiz-patch-1 branch 2 times, most recently from 736c2af to bc5d916 Compare November 22, 2022 12:55
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Base: 54.25% // Head: 54.11% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (3b87962) compared to base (a2aa6af).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   54.25%   54.11%   -0.15%     
==========================================
  Files        1814     1822       +8     
  Lines      120474   121287     +813     
  Branches    18525    18691     +166     
==========================================
+ Hits        65368    65639     +271     
- Misses      49888    50406     +518     
- Partials     5218     5242      +24     
Flag Coverage Δ
unittests 54.11% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otlin/com/soywiz/korge/gradle/KorgeVersionsTask.kt 0.00% <0.00%> (ø)
.../commonTest/kotlin/com/soywiz/korau/mod/MODTest.kt 75.00% <0.00%> (-25.00%) ⬇️
...n/kotlin/com/soywiz/korim/format/ImageAnimation.kt 85.71% <0.00%> (-14.29%) ⬇️
kds/src/commonMain/kotlin/com/soywiz/kds/Deque.kt 16.68% <0.00%> (-9.62%) ⬇️
...st/kotlin/com/soywiz/korio/vfs/MountableVfsTest.kt 71.87% <0.00%> (-9.38%) ⬇️
kds/src/commonMain/kotlin/com/soywiz/kds/Pool.kt 55.22% <0.00%> (-8.57%) ⬇️
...mmonTest/kotlin/com/soywiz/korio/vfs/ZipVfsTest.kt 74.72% <0.00%> (-7.70%) ⬇️
...monMain/kotlin/com/soywiz/kds/internal/internal.kt 71.05% <0.00%> (-6.10%) ⬇️
...n/com/soywiz/korge/atlas/AtlasResourceProcessor.kt 77.77% <0.00%> (-5.56%) ⬇️
...ommonTest/kotlin/com/soywiz/korge3d/ColladaTest.kt 89.18% <0.00%> (-5.41%) ⬇️
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz force-pushed the soywiz-patch-1 branch 2 times, most recently from 3ced1f2 to 42151d8 Compare November 23, 2022 13:00
@soywiz soywiz changed the title Try out Kotlin 1.8.0-Beta Try out Kotlin 1.8.0-RC Dec 10, 2022
@soywiz
Copy link
Member Author

soywiz commented Dec 11, 2022

e: file:///Users/runner/work/korge/korge/korgw/src/macosMain/kotlin/com/soywiz/korgw/DefaultGameWindowMacos.kt:55:5 'resetCursorRects' overrides nothing

Is this function not available anymore? https://developer.apple.com/documentation/appkit/nsview/1483448-resetcursorrects

@soywiz soywiz changed the title Try out Kotlin 1.8.0-RC Try out Kotlin 1.8.0-RC2 Dec 27, 2022
@soywiz soywiz changed the title Try out Kotlin 1.8.0-RC2 Try out Kotlin 1.8.0 Dec 28, 2022
@soywiz soywiz changed the title Try out Kotlin 1.8.0 Update to Kotlin 1.8.0 Dec 28, 2022
@soywiz soywiz marked this pull request as ready for review December 28, 2022 14:23
@soywiz soywiz merged commit 8820c03 into main Dec 28, 2022
@soywiz soywiz deleted the soywiz-patch-1 branch October 4, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants