Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native image encoding on native image formats #1120

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Nov 21, 2022

Fixes #1119

@codecov-commenter
Copy link

Codecov Report

Base: 54.03% // Head: 54.04% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (996481a) compared to base (ced7467).
Patch coverage: 37.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   54.03%   54.04%   +0.01%     
==========================================
  Files        1826     1827       +1     
  Lines      121885   121928      +43     
  Branches    19003    19008       +5     
==========================================
+ Hits        65856    65896      +40     
- Misses      50631    50648      +17     
+ Partials     5398     5384      -14     
Flag Coverage Δ
unittests 54.04% <37.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...z/korim/format/NativeImageFormatProviderAndroid.kt 2.21% <0.00%> (-0.11%) ⬇️
...Main/kotlin/com/soywiz/korim/format/ImageFormat.kt 53.27% <20.00%> (-4.98%) ⬇️
...tlin/com/soywiz/korim/format/ImageDataContainer.kt 71.42% <50.00%> (-8.58%) ⬇️
...m/soywiz/korim/format/NativeImageFormatProvider.kt 43.24% <50.00%> (-0.60%) ⬇️
...tlin/com/soywiz/korim/format/NativeEncodingTest.kt 71.42% <71.42%> (ø)
...oywiz/korim/format/NativeImageFormatProviderJvm.kt 90.00% <100.00%> (+5.38%) ⬆️
...monMain/kotlin/com/soywiz/korim/format/KorioExt.kt 70.12% <0.00%> (-1.30%) ⬇️
.../com/soywiz/korim/font/NativeSystemFontProvider.kt 53.17% <0.00%> (-0.80%) ⬇️
...ge/src/commonMain/kotlin/com/soywiz/korge/Korge.kt 39.61% <0.00%> (ø)
...onMain/kotlin/com/soywiz/korge/logger/LoggerExt.kt 12.50% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 5656959 into main Nov 22, 2022
@soywiz soywiz deleted the feature/native.image.encoding branch October 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JPEGInfo on iOS "Not implemented"
2 participants