Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using a pre-allocated array for QOI encoding to avoid allocating a new array for every call. #1098

Merged
merged 10 commits into from
Nov 12, 2022

Conversation

Kietyo
Copy link
Contributor

@Kietyo Kietyo commented Nov 9, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 53.23% // Head: 53.36% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (fe2b308) compared to base (cbc4b5f).
Patch coverage: 98.03% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
+ Coverage   53.23%   53.36%   +0.13%     
==========================================
  Files        1848     1856       +8     
  Lines      120330   120783     +453     
  Branches    18752    18811      +59     
==========================================
+ Hits        64052    64461     +409     
- Misses      51001    51006       +5     
- Partials     5277     5316      +39     
Flag Coverage Δ
unittests 53.36% <98.03%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmonTest/kotlin/com/soywiz/korim/format/QOITest.kt 94.44% <93.93%> (-0.30%) ⬇️
...Main/kotlin/com/soywiz/korim/format/ImageFormat.kt 58.24% <100.00%> (+1.91%) ⬆️
...c/commonMain/kotlin/com/soywiz/korim/format/QOI.kt 95.80% <100.00%> (+0.24%) ⬆️
...ck/src/commonMain/kotlin/com/soywiz/klock/Sleep.kt 0.00% <0.00%> (-50.00%) ⬇️
...e/src/commonTest/kotlin/com/soywiz/korge3d/test.kt 75.00% <0.00%> (-25.00%) ⬇️
...monTest/kotlin/com/soywiz/korim/format/EXIFTest.kt 75.00% <0.00%> (-25.00%) ⬇️
...monMain/kotlin/com/soywiz/korim/format/JPEGInfo.kt 83.33% <0.00%> (-16.67%) ⬇️
...mmonTest/kotlin/com/soywiz/korim/format/GIFTest.kt 84.61% <0.00%> (-15.39%) ⬇️
...ommonTest/kotlin/com/soywiz/korge3d/ColladaTest.kt 89.18% <0.00%> (-10.82%) ⬇️
...onTest/kotlin/com/soywiz/korio/vfs/LocalVfsTest.kt 70.00% <0.00%> (-8.34%) ⬇️
... and 61 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kietyo
Copy link
Contributor Author

Kietyo commented Nov 11, 2022

rdy

@soywiz
Copy link
Member

soywiz commented Nov 12, 2022

Lgtm. Thanks!

@soywiz soywiz merged commit ae89511 into korlibs:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants