fix Tolino Epos 2 to the correct light controller

[hugleo]

fix koreader/koreader#8482 (comment)

---

This change is 

[pazos]

Makes no sense to revert. It must be a FW thingy. @rola25: are you on the lastest firmware for your device? Which one?

Maybe I'm missing something,

[pazos]

Makes no sense to revert.

I mean, TolinoRoot was the initial implementation for warmth lights at all. Made by @zwim. It works but requires root.
Since then a new warmth driver is available. IIRC we never changed a driver for a device without an user report. So if every device is now on TolinoNtx it must be because they were reports on them (and because, if both work, the non-root option is better).

[hugleo]

IIRC we never changed a driver for a device without an user report.

We did, it was my fault here: https://github.com/koreader/android-luajit-launcher/pull/513/files#diff-7d3fed5a40ea52bd9274153219933a8cac5bdacd5622db82e3d45c8ed5fcbcb4L13.
You can go ahead and merge this PR, as it was a regression.

[pazos]

Thanks for the info, @hugleo

Now makes sense. Then please also change TOLINO_EPOS1

[hugleo]

Thanks for the info, @hugleo

Now makes sense. Then please also change TOLINO_EPOS1

For TOLINO_EPOS1 TolinoNtx seems to be good. koreader/koreader#8482 (comment)
At least until now nobody complains about this device.

[pazos]

For TOLINO_EPOS1 TolinoNtx seems to be good. koreader/koreader#8482 (comment)
At least until now nobody complains about this device.

Please no. Both on the same place. (Root!).
TOLINO EPOS 1 and 2 share warmth driver since the beginning :)

But the FW version thingy might apply. Newer firmwares might be compatible with the non-root implementation. The old root method might be invalid...
If somebody reports that a current driver no longer works and a new one works we would need to notice it an have a policy :/
Otherwise we will bump and dump drivers based on the FW of the people reporting :/.

[hugleo]

OK, done.

AFAIK, the root driver was developed and tested for the TOLINO EPOS 2.
For the TOLINO 1, I couldn't find any old reports indicating whether it works or doesn't work.

Good to know that they might still release new firmware for old TOLINOs even today. Next time, I'll buy a TOLINO! :D

[pazos]

Thanks!

For the TOLINO 1, I couldn't find any old reports indicating whether it works or doesn't work.

Both were "Root" before the regression.

Good to know that they might still release new firmware for old TOLINOs even today. Next time, I'll buy a TOLINO! :D

:))) I mean in general, like Onyxes or new tolino "vision" devices.

[hugleo]

Thanks!

For the TOLINO 1, I couldn't find any old reports indicating whether it works or doesn't work.

Both were "Root" before the regression.

Good to know that they might still release new firmware for old TOLINOs even today. Next time, I'll buy a TOLINO! :D

:))) I mean in general, like Onyxes or new tolino "vision" devices.

But they really do: https://mytolino.com/software-updates-for-tolino-ereaders/
16.2.0 2024 version is also available for Tolino Epos 1.

EDIT: 24 is the day not the year. The year is 2014. Is really too old :) Seems the OP can be the only one with the device alive.

ls -l
total 16644
-rw-r--r-- 1 hugleo hugleo 16 jul 24 2014 1872_1404_logo.jpg.header
-rw-r--r-- 1 hugleo hugleo 1314144 jul 24 2014 1872_1404_logo.jpg.raw4
-rw-r--r-- 1 hugleo hugleo 4538368 jul 24 2014 boot.img
-rw-r--r-- 1 hugleo hugleo 16 jul 24 2014 logo.jpg.header
-rw-r--r-- 1 hugleo hugleo 388096 jul 24 2014 logo.jpg.raw4
-rw-r--r-- 1 hugleo hugleo 16 jul 24 2014 mdpi_logo.jpg.header
-rw-r--r-- 1 hugleo hugleo 240000 jul 24 2014 mdpi_logo.jpg.raw4
drwxr-xr-x 2 hugleo hugleo 4096 dic 13 1901 META
drwxr-xr-x 3 hugleo hugleo 4096 nov 27 21:51 META-INF
-rw-r--r-- 1 hugleo hugleo 668330 jul 24 2014 ntx_hwconfig-static
drwxr-xr-x 3 hugleo hugleo 4096 nov 27 21:51 recovery
-rw-r--r-- 1 hugleo hugleo 6684672 jul 24 2014 recovery.img
drwxr-xr-x 2 hugleo hugleo 4096 dic 13 1901 res
drwxr-xr-x 13 hugleo hugleo 4096 nov 27 21:51 system
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E60K02.bin
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E60Q32.bin
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E60Q52.bin
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E60QF2.bin
-rw-r--r-- 1 hugleo hugleo 236700 jul 24 2014 u-boot_E60QJ2-DDR3.bin
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E60QJ2-LPDDR2.bin
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E60QV0.bin
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E70K00.bin
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E70Q22.bin
-rw-r--r-- 1 hugleo hugleo 236732 jul 24 2014 u-boot_E80K02.bin
-rw-r--r-- 1 hugleo hugleo 16 jul 24 2014 xhdpi_logo.jpg.header
-rw-r--r-- 1 hugleo hugleo 776128 jul 24 2014 xhdpi_logo.jpg.raw4

[rola25]

Hi, no I'm not on the latest firmware, mine is 16.1.0. I also have a Tolino Epos 1 - on weekend I can test koreader there.
I just upgraded to latest version 16.2.0 -> warmth does not work either. So I will wait for the new nightly build ;-)

[hugleo]

Can you test the Tolino Epos 1 on the eInk test and tell if will work TolinoRoot or TolinoNtx lights? This way we will have at least two reports on the device and can commit to the best option.

[rola25]

I tested it on the Tolino Epos 1 -> warmth is working there with both drivers, ntx and tolinoroot ... very strange ;-)
Do you need the device info? Hardware is e70q20 for Tolino Epos 1 and e80k00 for Tolino Epos 2

OK i debugged further:
I seems there is indeed no /sys/class/backlight/lm3630a_led/color on Epos 2 - it should be /sys/class/backlight/tlc5947_bl/color there:

Epos1:
root@ntx_6sl:/sys/class # ls -lR backlight/
backlight/:
lrwxrwxrwx root root 2012-01-01 02:36 lm3630a_led -> ../../devices/platform/imx-i2c.1/i2c-1/1-0038/backlight/lm3630a_led
lrwxrwxrwx root root 2012-01-01 03:37 lm3630a_leda -> ../../devices/platform/imx-i2c.1/i2c-1/1-0038/backlight/lm3630a_leda
lrwxrwxrwx root root 2012-01-01 03:37 lm3630a_ledb -> ../../devices/platform/imx-i2c.1/i2c-1/1-0038/backlight/lm3630a_ledb
lrwxrwxrwx root root 2012-01-01 02:36 mxc_msp430_fl.0 -> ../../devices/platform/mxc_msp430_fl.0/backlight/mxc_msp430_fl.0

Epos2:
root@ntx_6sl:/sys/class/backlight # ls -lR
lrwxrwxrwx root root 2024-11-29 10:32 mxc_msp430_fl.0 -> ../../devices/platform/mxc_msp430_fl.0/backlight/mxc_msp430_fl.0
lrwxrwxrwx root root 2024-11-29 10:30 tlc5947_bl -> ../../devices/platform/imx6q-ecspi.0/spi_master/spi0/spi0.0/backlight/tlc5947_bl

[hugleo]

@pazos I think that's all, go for the root here as work for both devices.

[Frenzie]

Isn't non-root preferable?

[hugleo]

Reading this comment: koreader/koreader#12843 is implying root I guess.

[pazos]

All non recent Nooks and Tolinos come with a closed version of android where their stock reading app is a big monolithic launcher.

Usually the way to "gain access" involves a way to get adb working and using adb to install an alternate launcher that lets you install and launch other apks.

New Tolino (vision?) comes with an Onyx/Mebook like launcher and with recent-ish android versions. Those devices are already "opened" but obtaining root in there might be difficult. No idea.

tl;dr: if v15 and v16 of the tolino epos1 firmware work with the non-root controller we can upgrade. Otherwise stay as is, root is easily achievable in "closed" tolinos.

[hugleo]

What do you prefer? merge this as is or revert to ntx?

[pazos]

@hugleo koreader/koreader#12843 (comment)

Now I think the non-root is better. Hopefully works on v16 too. Who knows?

[hugleo]

@hugleo koreader/koreader#12843 (comment)

Now I think the non-root is better. Hopefully works on v16 too. Who knows?

hmm. let be ntx for now then.