ISteamUserStats and ISteamApps support #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to check that the correct operations are called, to prevent this issue happening again.
…se are now unit tested correctly. Removed some logic that was handling the data returned in these requests, which consequently will not be called.
… refactoring and added comments.
… assist this change.
|
I just want to mention that this looks very promising. Please keep up your good work. |
|
No problem, I appreciate that you've got other things to do too :) I'm working towards getting koraktor/steam-condenser#195 resolved, and when its required a new service I've implemented all operations, as they aren't that big. I've started on IPlayerService and I believe ISteamUser will need to be completed too. |
|
So I'm gonna start working on this again, been busy with work and now I'm back and have some spare time :) Once I've got a fuller list I'll do the pull request again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've now covered the operations for both ISteamUserStats and ISteamApps, fully unit tested and commented.
Covers Issues koraktor/steam-condenser#157, koraktor/steam-condenser#197 and koraktor/steam-condenser#200