-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: fix prodReclaimablePredictor result to avoid influence of o… #2325
koordlet: fix prodReclaimablePredictor result to avoid influence of o… #2325
Conversation
f068dab
to
a13d624
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2325 +/- ##
==========================================
- Coverage 66.09% 66.08% -0.02%
==========================================
Files 458 458
Lines 54200 54270 +70
==========================================
+ Hits 35823 35862 +39
- Misses 15803 15828 +25
- Partials 2574 2580 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4f05190
to
6cfc773
Compare
…versold Signed-off-by: lijunxin <lijunxin.ljx@alibaba-inc.com>
6cfc773
to
7c9ac0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
PTAL /cc @zwzhang0107 @hormes @jasonliu747 |
…versold
Ⅰ. Describe what this PR does
When calculating Allocatable[mid] resources, due to possible oversold, ProdReclaimableMetric will be greater than NodeAllocatable * thresholdRatio, so the calculated Allocatable[mid] value accidentally includes the oversold part. However, our previous attempts at modifying the computational model in PR #2291 were not sufficient as they would erase the role of the prodPod estimation model, resulting in the loss of the more stable mid resource characteristics after modification. Therefore, further modifications to the prodPod are needed.
Ⅱ. Does this pull request fix one issue?
Therefore, I optimized the behavior of ProdReclaimablePredictor by adjusting the values based on the node's runtime information when returning the prediction results, thereby affecting the collectMetric results. And added necessary related tests has proved that the modified calculations are reasonable.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test