-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: revise ReservationFilterPlugin and fix preempting pods resources #2315
Merged
koordinator-bot
merged 2 commits into
koordinator-sh:main
from
saintube:scheduler-enhance-reservation-filter
Jan 10, 2025
Merged
scheduler: revise ReservationFilterPlugin and fix preempting pods resources #2315
koordinator-bot
merged 2 commits into
koordinator-sh:main
from
saintube:scheduler-enhance-reservation-filter
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
==========================================
- Coverage 66.04% 66.02% -0.03%
==========================================
Files 458 458
Lines 53947 53984 +37
==========================================
+ Hits 35631 35644 +13
- Misses 15757 15776 +19
- Partials 2559 2564 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saintube
force-pushed
the
scheduler-enhance-reservation-filter
branch
from
January 8, 2025 01:46
bc4666d
to
c96c408
Compare
/lgtm |
ZiMengSheng
reviewed
Jan 8, 2025
ZiMengSheng
reviewed
Jan 8, 2025
saintube
force-pushed
the
scheduler-enhance-reservation-filter
branch
from
January 8, 2025 02:53
c96c408
to
df11698
Compare
ZiMengSheng
reviewed
Jan 8, 2025
/lgtm |
saintube
force-pushed
the
scheduler-enhance-reservation-filter
branch
from
January 8, 2025 06:53
df11698
to
570f709
Compare
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
scheduler-enhance-reservation-filter
branch
from
January 9, 2025 03:11
570f709
to
7275544
Compare
saintube
changed the title
scheduler: revise ReservationFilterPlugin
scheduler: revise ReservationFilterPlugin and fix preempting pods resources in reservation
Jan 9, 2025
saintube
changed the title
scheduler: revise ReservationFilterPlugin and fix preempting pods resources in reservation
scheduler: revise ReservationFilterPlugin and fix preempting pods resources
Jan 9, 2025
/lgtm |
hormes
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Koord-Scheduler:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
Rename the ReservationFilterPlugin method
FilterReservation
toFilterNominateReservation
since only the NominateReservation calls it during the PreScore or the Reserve phase.Re-define the method
FilterReservation
that is invoked in the Filter phase:Compared with the current FilterReservation which runs in the PreScore or Reserve, the new method is invoked during the Filter phase of the reservation plugin. It should show more concise reasons when the scheduling fails, and it is helpful for internal extensions.
In this version, we keep the FilterNominateReservation and will move the current implementation to the Filter phase in the future.
V. Checklist
make test