Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: register pod delete event for resource plugin #2308

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.03%. Comparing base (e49c43d) to head (7ef2507).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/plugins/deviceshare/plugin.go 0.00% 1 Missing ⚠️
pkg/scheduler/plugins/loadaware/load_aware.go 0.00% 1 Missing ⚠️
pkg/scheduler/plugins/nodenumaresource/plugin.go 0.00% 1 Missing ⚠️
pkg/scheduler/plugins/reservation/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   66.03%   66.03%           
=======================================
  Files         458      458           
  Lines       53921    53925    +4     
=======================================
+ Hits        35607    35612    +5     
  Misses      15757    15757           
+ Partials     2557     2556    -1     
Flag Coverage Δ
unittests 66.03% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube
Copy link
Member

@ZiMengSheng Does ElasticQuota plugin need this? /cc @shaloulcy

@ZiMengSheng
Copy link
Contributor Author

@ZiMengSheng Does ElasticQuota plugin need this? /cc @shaloulcy

Yes, it needs and it already has this

@hormes
Copy link
Member

hormes commented Jan 7, 2025

/lgtm

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot merged commit 9f5f964 into koordinator-sh:main Jan 9, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants