-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add close for querier #1995
koordlet: add close for querier #1995
Conversation
dc25cf3
to
d623153
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
==========================================
+ Coverage 67.50% 68.67% +1.17%
==========================================
Files 421 421
Lines 47100 38839 -8261
==========================================
- Hits 31795 26673 -5122
+ Misses 12990 9860 -3130
+ Partials 2315 2306 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d623153
to
ed307aa
Compare
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
ed307aa
to
8a798c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
#1981
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test