Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add pod resctrl #1974

Closed

Conversation

kangclzjc
Copy link
Member

Ⅰ. Describe what this PR does

This PR will enhance pod level resctrl which adjust pod level LLC/MB.

Ⅱ. Does this pull request fix one issue?

#1831

Ⅲ. Describe how to verify it

create a pod with annotation like below. And check /sys/fs/resctrl/koordlet-podid/schemata

{
  "llc": {
    "schemata": {
      "range": [20,80],
    },
    "schemataPerCache": [
      {
        "cacheid" : 0,
        "range": [20,50]
      },
      {
        "cacheid" : 1,
        "range": [20,60]
      },
    ],
  },
  "mb": {
    "schemata": {
      "percent": 20,
    },
    "schemataPerCache": [
      {
        "cacheid": 0,
        "percent": 20
      },
      {
        "cacheid": 1,
        "percent": 40
      },
    ],
  }
}

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from jasonliu747 and ZYecho March 27, 2024 09:19
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign honpey, jasonliu747 after the PR has been reviewed.
You can assign the PR to them by writing /assign @honpey @jasonliu747 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kangclzjc kangclzjc changed the title add pod resctrl koordlet: add pod resctrl Mar 27, 2024
@kangclzjc kangclzjc force-pushed the dev-resctrl-pod-control branch 2 times, most recently from af981bf to 66f588e Compare April 25, 2024 08:51
@kangclzjc
Copy link
Member Author

@saintube PTAL.

@kangclzjc kangclzjc force-pushed the dev-resctrl-pod-control branch from 80dd89b to 9f47f1d Compare April 30, 2024 07:56
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 24.00000% with 209 lines in your changes missing coverage. Please review.

Project coverage is 68.45%. Comparing base (af172b1) to head (9f47f1d).
Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
pkg/koordlet/runtimehooks/reconciler/reconciler.go 1.69% 57 Missing and 1 partial ⚠️
pkg/koordlet/runtimehooks/protocol/pod_context.go 0.00% 38 Missing and 1 partial ⚠️
pkg/koordlet/statesinformer/impl/states_pods.go 35.29% 29 Missing and 4 partials ⚠️
pkg/koordlet/util/system/resctrl.go 34.88% 26 Missing and 2 partials ⚠️
pkg/koordlet/resourceexecutor/resctrl_updater.go 53.70% 23 Missing and 2 partials ⚠️
pkg/koordlet/runtimehooks/nri/server.go 0.00% 11 Missing ⚠️
pkg/koordlet/runtimehooks/protocol/protocol.go 0.00% 10 Missing ⚠️
...oordlet/runtimehooks/protocol/container_context.go 0.00% 2 Missing and 1 partial ⚠️
...et/qosmanager/plugins/resctrl/resctrl_reconcile.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
- Coverage   68.78%   68.45%   -0.34%     
==========================================
  Files         422      423       +1     
  Lines       39058    39466     +408     
==========================================
+ Hits        26866    27016     +150     
- Misses       9865    10106     +241     
- Partials     2327     2344      +17     
Flag Coverage Δ
unittests 68.45% <24.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Copy link

stale bot commented Jul 29, 2024

This issue has been automatically marked as stale because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close
    Thank you for your contributions.

Copy link

stale bot commented Aug 28, 2024

This issue has been automatically closed because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Reopen this PR with /reopen
    Thank you for your contributions.

@stale stale bot closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant