Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "scheduler : fix deviceshare plugin of add\remove pod (#1963)" #1971

Merged

Conversation

xulinfei1996
Copy link
Contributor

This reverts commit ad01533.

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…tor-sh#1963)

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (ad01533) to head (0eac586).

Files Patch % Lines
pkg/scheduler/plugins/deviceshare/plugin.go 86.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1971      +/-   ##
==========================================
- Coverage   67.62%   67.54%   -0.09%     
==========================================
  Files         421      420       -1     
  Lines       47146    47059      -87     
==========================================
- Hits        31881    31784      -97     
- Misses      12954    12962       +8     
- Partials     2311     2313       +2     
Flag Coverage Δ
unittests 67.54% <86.66%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buptcozy
Copy link
Contributor

/lgtm

@buptcozy
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit cd58ac6 into koordinator-sh:main Mar 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants