Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce main for runtime-manager #171

Merged
merged 1 commit into from
May 26, 2022

Conversation

honpey
Copy link
Contributor

@honpey honpey commented May 25, 2022

Signed-off-by: honpey honpey@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@koordinator-bot koordinator-bot bot requested review from hormes and yihuifeng May 25, 2022 12:41
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #171 (192125f) into main (226f8ba) will increase coverage by 0.47%.
The diff coverage is n/a.

❗ Current head 192125f differs from pull request most recent head e7bce5e. Consider uploading reports for the commit e7bce5e to get more accurate results

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   57.82%   58.30%   +0.47%     
==========================================
  Files          91       92       +1     
  Lines        8159     8370     +211     
==========================================
+ Hits         4718     4880     +162     
- Misses       3029     3077      +48     
- Partials      412      413       +1     
Flag Coverage Δ
unittests 58.30% <ø> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/config.go 56.25% <0.00%> (-2.09%) ⬇️
pkg/koordlet/resmanager/resmanager.go 56.66% <0.00%> (-1.46%) ⬇️
pkg/koordlet/resmanager/cpu_evict.go 74.12% <0.00%> (ø)
pkg/koordlet/resmanager/metrics_query.go 66.32% <0.00%> (+9.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226f8ba...e7bce5e. Read the comment docs.

Makefile Show resolved Hide resolved
@honpey honpey force-pushed the runtime-manager-dev branch from d56cead to 192125f Compare May 25, 2022 13:42
@honpey honpey force-pushed the runtime-manager-dev branch 2 times, most recently from 1724721 to 8fa2a0f Compare May 25, 2022 14:02
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
others PTAL

Signed-off-by: honpey <honpey@gmail.com>
@honpey honpey force-pushed the runtime-manager-dev branch from 8fa2a0f to e7bce5e Compare May 26, 2022 02:01
@koordinator-bot koordinator-bot bot removed the lgtm label May 26, 2022
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label May 26, 2022
@hormes
Copy link
Member

hormes commented May 26, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 093647a into koordinator-sh:main May 26, 2022
@honpey honpey deleted the runtime-manager-dev branch May 26, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants