Introduce image service proxy under cri scenario #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 57.82% 57.82%
=======================================
Files 91 91
Lines 8159 8159
=======================================
Hits 4718 4718
Misses 3029 3029
Partials 412 412
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
for kubelet, when --image-service-endpoint is not set, kubelet would use the runtime socket as the image-service endpoint. under kubelet using runtime-manager as remote runtime and image-service not configured scenario : kubelet xx --container-runtime-endpoint=/var/run/runtime-manager/runtimemanager.sock runtime-manager should implement image service proxy, otherwise there would be image related errors as no image-service exists. runtime-manager just forwards image request to backend containerd tranparently. Signed-off-by: honpey <honpey@gmail.com>
honpey
force-pushed
the
runtime-manager-dev
branch
from
4258821 to
a757cb8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for kubelet, when --image-service-endpoint is not set, kubelet would use
the runtime socket as the image-service endpoint.
under kubelet using runtime-manager as remote runtime and image-service not configured scenario :
kubelet xx --container-runtime-endpoint=/var/run/runtime-manager/runtimemanager.sock
runtime-manager should implement image service proxy, otherwise there would be image related errors
as no image-service exists.
runtime-manager just forwards image request to backend containerd tranparently.
Signed-off-by: honpey honpey@gmail.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews