-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal load-aware scheduling plugin #135
proposal load-aware scheduling plugin #135
Conversation
Ref #95 |
bc3b337
to
63b447f
Compare
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 56.38% 55.45% -0.93%
==========================================
Files 78 83 +5
Lines 7366 7787 +421
==========================================
+ Hits 4153 4318 +165
- Misses 2840 3086 +246
- Partials 373 383 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
63b447f
to
71950e4
Compare
@jasonliu747 @saintube I updated the proposal with extend NodeMetricSpec to support user-defined reporting period and aggregation period. |
6bc8087
to
dd9a29c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall. However, I think some variables can have a better naming. We can figure it out later. Others have any suggestions?
/lgtm
dd9a29c
to
fb0624a
Compare
8e0951d
to
b078f4d
Compare
Please add a record in the section of unsolved problems to support portraits of different periods. For example, long-running pods need to be scheduled with long-period profiling, while short-period pods should be scheduled with short-period profiling. |
b078f4d
to
ab5e1af
Compare
Signed-off-by: Tao Li <joseph.t.lee@outlook.com>
ab5e1af
to
82d6eae
Compare
Updated. @hormes |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tao Li joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
Although Koordinator provides the co-location mechanism to improve the resource utilization of the cluster and reduce costs, it does not yet have the ability to control the utilization level of the cluster dimension. This proposal defines a scheduling plugin to help Koordinator achieve this capability.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews