-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce cri request parsing/generate-hook-request/checkpoing logic #110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 54.34% 54.34%
=======================================
Files 77 77
Lines 7277 7277
=======================================
Hits 3955 3955
Misses 2972 2972
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! only few suggestions.
return &NoopResourceExecutor{} | ||
} | ||
|
||
type NoopResourceExecutor struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does Noop
stand for? Could you please elaborate on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
Noop
mean? Could you explain briefly?
Noop means no-operation for cri request, where no hook exists like ListContainerStats/ExecSync etc.
comments has beed added.
11e1abe
to
7913924
Compare
Signed-off-by: pengyang.hpy <honpey@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews