Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing NodeSLO CRD #15

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Apr 7, 2022

Signed-off-by: Tao Li joseph.t.lee@outlook.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to master. They are not published on branches.

Signed-off-by: Tao Li <joseph.t.lee@outlook.com>
@koordinator-bot koordinator-bot bot requested a review from stormgbs April 7, 2022 12:18
@eahydra eahydra closed this Apr 7, 2022
@eahydra eahydra reopened this Apr 7, 2022
@jasonliu747
Copy link
Member

Fixes koordinator-sh/koordinator#49

@eahydra eahydra force-pushed the fix_missing_crd branch 3 times, most recently from 4454b97 to a0bfe7c Compare April 7, 2022 12:52
Signed-off-by: Tao Li <joseph.t.lee@outlook.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eahydra
Copy link
Member Author

eahydra commented Apr 7, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 848c135 into koordinator-sh:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants