fix: pass labelStyleProps down to FormLabel #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoviana
force-pushed
the
allow-label-style-props
branch
2 times, most recently
from
486f75e to
412fbcf
Compare
|
This looks good, thanks for sending this. I will review and respond shortly. |
koolamusic
reviewed
Mar 29, 2021
src/index.tsx
Outdated
| @@ -191,7 +191,7 @@ export const CUIAutoComplete = <T extends Item>( | |||
|
|
|||
| return ( | |||
| <Stack> | |||
| <FormLabel {...getLabelProps({})}>{label}</FormLabel> | |||
| <FormLabel {...labelStyleProps} {...getLabelProps({})}>{label}</FormLabel> | |||
There was a problem hiding this comment.
Do you think we can do something like :
<FormLabel {...labelStyleProps, ...getLabelProps({})}>{label}</FormLabel>
There was a problem hiding this comment.
I think so! thanks for the suggestion 😄
joaoviana
force-pushed
the
allow-label-style-props
branch
from
412fbcf to
af6a2e6
Compare
|
done @koolamusic, LMK if you prefer this approach 👍 |
|
Looks good to me. Thanks for making this happen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: #24
@koolamusic updated snapshots, anything else I'm missing? 😄