Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ tags table change button styles #2119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TalyaNaima
Copy link

@TalyaNaima TalyaNaima commented Oct 8, 2024

changing the style of the edit & delete buttons in tags table (including the tags category)
Part of #1318

before the changes (using patternFly-4):
image
after the changes (using patternFly-5):
image

UI tests PR:#1237

TalyaNaima and others added 2 commits September 22, 2024 13:14
Signed-off-by: TalyaNeima <talya.brajtman@gmail.com>
Signed-off-by: TalyaNaima <Ttalya.brajtman@gmail.com>
@TalyaNaima TalyaNaima changed the title ✨ Talya&Hadasah t table ✨ tags table change button styles Oct 8, 2024
@TalyaNaima TalyaNaima changed the title ✨ tags table change button styles ✨ tags table change button styles issue #1318 Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.97%. Comparing base (b654645) to head (d37a868).
Report is 240 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
+ Coverage   39.20%   41.97%   +2.77%     
==========================================
  Files         146      175      +29     
  Lines        4857     5629     +772     
  Branches     1164     1415     +251     
==========================================
+ Hits         1904     2363     +459     
- Misses       2939     3145     +206     
- Partials       14      121     +107     
Flag Coverage Δ
client 41.97% <ø> (+2.77%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mguetta1 mguetta1 changed the title ✨ tags table change button styles issue #1318 ✨ tags table change button styles Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant